Merged
Conversation
Slashek
reviewed
Mar 17, 2026
packages/platformos-check-common/src/checks/missing-render-partial-arguments/index.spec.ts
Outdated
Show resolved
Hide resolved
Slashek
reviewed
Mar 17, 2026
packages/platformos-check-common/src/checks/nested-graphql-query/index.spec.ts
Show resolved
Hide resolved
Slashek
reviewed
Mar 17, 2026
packages/platformos-check-common/src/checks/nested-graphql-query/index.ts
Outdated
Show resolved
Hide resolved
Slashek
reviewed
Mar 17, 2026
packages/platformos-check-common/src/checks/nested-graphql-query/index.ts
Outdated
Show resolved
Hide resolved
Slashek
reviewed
Mar 17, 2026
packages/platformos-check-common/src/checks/translation-key-exists/index.ts
Outdated
Show resolved
Hide resolved
Slashek
reviewed
Mar 17, 2026
packages/platformos-check-common/src/checks/translation-key-exists/index.ts
Outdated
Show resolved
Hide resolved
Slashek
reviewed
Mar 17, 2026
| email: | ||
| type: string | ||
| --- | ||
| {{ params.token }} |
Contributor
There was a problem hiding this comment.
hmmm. It doesn't work like that, does it? You can access page metadata through context.page.metadata.*
Contributor
There was a problem hiding this comment.
In this test, I don't even know if this is a partial or a page; partial metadata can't be accessed through liquid, I guess, they can only be fetched through GraphQL.
Slashek
reviewed
Mar 17, 2026
packages/platformos-check-common/src/checks/undefined-object/index.ts
Outdated
Show resolved
Hide resolved
Slashek
reviewed
Mar 17, 2026
packages/platformos-check-common/src/checks/unused-translation-key/index.spec.ts
Outdated
Show resolved
Hide resolved
Slashek
reviewed
Mar 17, 2026
packages/platformos-check-common/src/checks/unused-translation-key/index.ts
Outdated
Show resolved
Hide resolved
Slashek
reviewed
Mar 17, 2026
packages/platformos-check-common/src/checks/unused-translation-key/index.spec.ts
Outdated
Show resolved
Hide resolved
Slashek
reviewed
Mar 17, 2026
packages/platformos-check-common/src/checks/unused-translation-key/index.ts
Outdated
Show resolved
Hide resolved
Slashek
reviewed
Mar 17, 2026
Slashek
reviewed
Mar 17, 2026
...ages/platformos-language-server-common/src/hover/providers/GraphQLFieldHoverProvider.spec.ts
Show resolved
Hide resolved
Slashek
reviewed
Mar 17, 2026
packages/platformos-language-server-common/src/server/startServer.spec.ts
Outdated
Show resolved
Hide resolved
Slashek
reviewed
Mar 17, 2026
Co-authored-by: Maciej Krajowski-Kukiel <krajek6@gmail.com>
Slashek
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linting Checks (platformos-check-common):
TranslationKeyExists enhancement — When a translation key doesn't exist, suggests the nearest valid key using Levenshtein distance (e.g., general.titel → "Did you mean general.title?"). Also introduces shared levenshtein and flattenTranslationKeys utilities.
NestedGraphQLQuery (new check) — Detects {% graphql %} tags inside {% for %} or {% tablerow %} loops (N+1 query pattern). Downgrades to INFO severity if wrapped in {% cache %}, and ignores {% background %} blocks.
MissingRenderPartialArguments (new check) — When rendering a partial that has {% doc %} with @param declarations, reports an error if required parameters are missing from the {% render %} call. Includes fix suggestions.
LSP Features (platformos-language-server-common):